Closed jhcollins closed 4 years ago
The tests I wrote are failing on travis but working locally so I'm in the middle of debugging that
okay, the proteus_tutorials tests are now resulting in the expected behavior (i.e. pass for non moving mesh, fail for moving mesh in parallel)
@jhcollins, great. Thanks for this.
On my end, there's still a bit of a hiccup with the parallel run on the fix.
@zhang-alvin is the change you requested correct? if so, would you mind approving it?
@zhang-alvin is the change you requested correct? if so, would you mind approving it?
It looks right.
Thanks. The parallel floating body test just passed btw
Merging #1210 into master will decrease coverage by
3.48%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
- Coverage 50.87% 47.39% -3.49%
==========================================
Files 526 521 -5
Lines 108803 108663 -140
==========================================
- Hits 55358 51504 -3854
- Misses 53445 57159 +3714
Impacted Files | Coverage Δ | |
---|---|---|
proteus/tests/FSI/floatingCube.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
proteus/tests/AddedMass/addedmass3D.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
proteus/tests/MoveMeshMonitor/moveMesh_n.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
proteus/tests/MoveMeshMonitor/moveMesh_p.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...teus/tests/solver_tests/test_dof_order_routines.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
.../solver_tests/import_modules/nseDrivenCavity_2d.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...solver_tests/test_bochev_pressure_stabilization.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...lver_tests/import_modules/stokesDrivenCavity_2d.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...s/import_modules/twp_navier_stokes_cavity_2d_so.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...ctor/import_modules/mass_matrix_reference_TH_2D.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
... and 76 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4571f06...91732c0. Read the comment docs.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description
As part of the addition of the proteus_tutorial simulations to the tests, I am including the repo as a submodule in proteus/tests. Happy to move it wherever you see fit.
No new files Code coverage does not decrease No new feature