erdc / proteus

A computational methods and simulation toolkit

http://proteustoolkit.org

MIT License

88 stars 56 forks source link

Skip boundarys with non-positive tags (ghost boundaries) #1222

Closed cekees closed 4 years ago

cekees commented 4 years ago

This is re-enabling a default behavior for boundaries tagged zero or less. That is, skip them. I used a continue statement so this happens at the top level of the loop so there are no calculations or contributions on boundaryFlag < 1.

Mandatory Checklist

Please ensure that the following criteria are met:

[x] Title of pull request describes the changes/features
[x] Request at least 2 reviewers
[x] If new files are being added, the files are no larger than 100kB. Post the file sizes.
[x] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
[ ] New features have appropriate documentation strings (readable by sphinx)
[x] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

codecov[bot] commented 4 years ago

Codecov Report

Merging #1222 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   52.14%   52.14%           
=======================================
  Files         528      528           
  Lines      109012   109012           
=======================================
  Hits        56847    56847           
  Misses      52165    52165

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a7c590...48246df. Read the comment docs.