erdc / proteus

A computational methods and simulation toolkit
http://proteustoolkit.org
MIT License
88 stars 56 forks source link

Replace recordtype using standard dataclasses module #1260

Closed cekees closed 2 years ago

cekees commented 2 years ago

Mandatory Checklist

Please ensure that the following criteria are met:

As a general rule of thumb, try to follow PEP8 guidelines.

Description

cekees commented 2 years ago

@jan-janssen does this work for you?

jan-janssen commented 2 years ago

@jan-janssen does this work for you?

That is an even cleaner solution - thanks!

cekees commented 2 years ago

@jhcollins I had accidentally reverted the change to https for submodule URL's, but that is fixed here. What I do if I need to work on submodule code is use git remote set-url... to switch to git@github.com in the submodule so I can push changes, which doesn't affect the protocol specified in .gitmodules.