Update Two Gintama Entries

erengy / anime-relations

Episode redirections for Taiga

https://github.com/erengy/taiga

Creative Commons Zero v1.0 Universal

87 stars 69 forks source link

Update Two Gintama Entries #85

Closed mnabid closed 2 years ago

mnabid commented 3 years ago

Gintama.: Shirogane no Tamashii-hen is split cour (12 + 14). So, Ep 13-26 (first cour) -> Ep 1-14 (second cour). Mini encoder groups like Judas ~~and Kayoanime~~ have all 26 episodes together.
Added Gintama: The Semi-Final as well.

paulo27ms commented 3 years ago

Is this new line really necessary?

36838|14095|100784:354-367 -> 37491|41079|101925:1-14 Should already be handled by
918|818|918:354-367 -> 37491|41079|101925:1-14!

erengy commented 3 years ago

Hey @mnabid, thanks for the PR.

The first rule works for Judas, which is currently the most popular release on Nyaa. Should be merged, I think.

The second rule doesn't seem to be necessary, as @paulo27ms noted.

I couldn't find any releases that require the rule for The Semi-Final either. Did I miss some, or was the rule added as a precaution?

mnabid commented 3 years ago

@paulo27ms Sorry for the late reply, I was away from home.

Is this new line really necessary?

Pretty sure it is, if I understood the README correctly.

Gintama/
├── (...)
├── Episode 342-353
├── Episode 354-367
└── (...)

This scenario should be covered by the exisiting rules you mentioned. But it won't work in the following case:

Gintama.: Shirogane no Tamashii-hen/
├── Episode 342-353
├── Episode 354-367

This is where the new line comes into play. (I actually copy-pasted this rule from AoT Season 3 Part 2)

https://github.com/erengy/anime-relations/blob/b404cfc27ed47e79b7f486f0c1f1952ea873d282/anime-relations.txt#L820-L824

mnabid commented 3 years ago

@erengy

I couldn't find any releases that require the rule for The Semi-Final either. Did I miss some, or was the rule added as a precaution?

Precaution. Gintama wiki and filler list listed these two episodes as 368-369.

paulo27ms commented 3 years ago

I suppose it is fine, it's just that in those cases you could just set an alternative title for that entry and it'd apply the already existing rule. Didn't realize AoT had it too. The extra rule shouldn't cause any conflict anyway I guess.

mnabid commented 2 years ago

Hi @erengy, it's been quite a long time. Would you mind reviewing it again? I replied about the relevance of the 2nd and 3rd rule. Let me know if I need to make any changes.

erengy commented 2 years ago

Hey @mnabid, thanks for the explanations.

I spent another hour contemplating this, but in the end, decided against adding the latter two rules. You're right about that case, but I think we should work with existing releases rather than trying to cover every possible scenario.

I'll merge the first rule after removing the !, otherwise it could redirect episodes 13-14 back to 1-2 (because source and destination ranges are overlapping).