erengy / taiga

A lightweight anime tracker for Windows
https://taiga.moe
GNU General Public License v3.0
2.11k stars 227 forks source link

Issue with Automatic downloading and ASCII #998

Open master117 opened 3 years ago

master117 commented 3 years ago

Taiga refused to add Several Anime to my deluge in the past. I looked into it for Vivy from this Season. The problem seems to be that it retains Unicode characters in torrent names.

I tried to add a torrent while running Taiga in Debug mode and found:

2021-04-20 13:41:57 [Debug] feed_aggregator.cpp:397 Aggregator::HandleFeedDownloadOpen | >>

Application: C:\Program Files (x86)\Deluge\deluge-console.exe

Parameters: add -p \"Z:\Anime\Vivy Fluorite Eye’s Song\" \"C:\Users\johan\AppData\Roaming\Taiga\data\feed\bnlhYS5zaQ==\[SubsPlease] Vivy - Fluorite Eye's Song - 01 (1080p) [C12541D5].mkv.torrent\"

The different ' seem to be the issue here. I reproduced the command in PS and received:

PS C:\Program Files (x86)\Deluge> .\deluge-console.exe add -p \"Z:\Anime\Vivy Fluorite Eye's Song\" \"C:\Users\johan\AppData\Roaming\Taiga\data\feed\bnlhYS5zaQ==\[SubsPlease] Vivy - Fluorite Eye's Song - 01 (1080p) [C12541D5].mkv.torrent\"

Error parsing command: 'ascii' codec can't encode character u'\u2019' in position 33: ordinal not in range(128)

Which indicates that deluge doesn't support the torrent files name. Is there a way to configure Taiga to use normalized names?

paulo27ms commented 3 years ago

This seems like something you'd ask the deluge devs... Does changing the name of the torrent file even fix this?

master117 commented 3 years ago

Well, Taiga is not downloading the files with sanitized names and deluge is struggling with reading non sanitized names. Changes on either side would work for me. But a "fix" from Taigas side may also be beneficial for other torrent clients.

Changing the torrent filename fixes the problem.