Closed jameshartig closed 8 years ago
This looks terrific. I've gone ahead and activated travis for this repo. Know a way to triggering a travis check for this PR?
I'll just force push and that'll trigger it
Unfortunately it cannot on the faster travis servers (which use containers) because we need sudo to edit the hosts file. I'm looking into that and I'll make a separate PR. I think the boulder stuff runs their own DNS server that returns 127.0.0.1
for everything so we might not even need to edit the hosts file anymore.
Maybe something like this? https://docs.travis-ci.com/user/hosts/
I tried that but it didn't set them to localhost :/
Looks like it failed the DNS challenge in the test, let me look into it again and I'll update that version.
FYI take a look at https://github.com/ericchiang/travis-tests/pull/1. The hosts addon does point entries at 127.0.0.1.
Looks like the test is failing because listen tcp 127.0.0.1:8053: bind: address already in use
. So I need to run the dns server on a different port. Hmm, I'll try the hosts keyword again but when I first tried it, the tests complained the hosts file wasn't updated.
It was resolving to ::1
not 127.0.0.1
. I'll update the tests.
@ericchiang I updated it to use the built-in DNS server that boulder exposes which means I got rid of the new godep. I also updated the go version and travis seems happy now :)
Thanks for the quick merge @ericchiang!
I added a
.travis.yml
so PRs and master can be built in Travis CI. It was pretty complicated since it has to build and start boulder but after a lot of trial and error I got it working. I couldn't test the final push since the import paths are wrong (github.com/ericchiang/letsencrypt
vsgithub.com/levenlabs/letsencrypt
) but if you turn on Travis CI support we can make sure this PR passes.I also added DNS challenge support. This required that I included
github.com/miekg/dns
package in godeps so that breaks the diff :disappointed: so I moved that out into a separate commit so you can review the travis and dns commits separately.I also added:
to the
ChallengeReady
loop since if you're using DNS, the old value or the non-existent value might be cached, so it will continue looping as long as the error is one of those. Let me know what you think.Fixes #2