ericlanvin / mt4tradeduplicator

Automatically exported from code.google.com/p/mt4tradeduplicator
0 stars 0 forks source link

Order modify sl/tp doesn't work #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create order, no sl/tp
2. Modify order to add sl, tp
3. Target system cannot find ticket 1 to update sl, tp

Problem is in processing of modified order - parameters to
BetterOrderModify have omitted OrderType - is truncating OrderOpenPrice()
and traeting it as ticket

Original issue reported on code.google.com by Ian.P.Jo...@btinternet.com on 22 Jan 2010 at 12:10

GoogleCodeExporter commented 9 years ago
See the issue and will fix tonight.

Original comment by dwmcqu...@gmail.com on 10 Jun 2010 at 12:56

GoogleCodeExporter commented 9 years ago
Should be fixed.  Please try recent update.

Original comment by dwmcqu...@gmail.com on 13 Jun 2010 at 9:06

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I tried the update, no improvement:unknown ticket 1 for OrderModify function

I only added the OrderType(), no improvement
I copy pasted the whole contents, no improvement.

Is it possible that you upload readymade EA?, or much better the new zip file.

Original comment by emailofn...@gmail.com on 17 Jun 2010 at 7:48

GoogleCodeExporter commented 9 years ago
seems like the zip file still contains the old EA and not the updated EA.
can you please upload a new set of files?

Original comment by avgua...@gmail.com on 25 Jun 2010 at 9:58

GoogleCodeExporter commented 9 years ago
I have it fixed. the problem was with the order of parameters when call 
BetterOrderModify namely OrderTicket() and OrderType().

From 

BetterOrderModify(OrderSymbol(), OrderTicket(), OrderType(), OrderOpenPrice(), 
StoredOrderStopLoss[i],StoredOrdeTakeProfit[i], 0,Blue);

Changed To

BetterOrderModify(OrderSymbol(), OrderType(), OrderTicket(), OrderOpenPrice(), 
StoredOrderStopLoss[i],StoredOrdeTakeProfit[i], 0,Blue);

Original comment by avgua...@gmail.com on 25 Jun 2010 at 12:52