search

ericmckean / naclports

Automatically exported from code.google.com/p/naclports
0 stars 0 forks source link

git autocrlf behaviour of naclports should be locally set on OSX #127

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. check out the ports according to the docs
2. try to build zlib with ./make_all.sh zlib

What is the expected output? What do you see instead?

Building zlib and other ports pulling git repos are stopping due to default 
autocrlf settings:

MacBook-Pro-Hartmut:src hartmut$ ./make_all.sh zlib
+ set -e
+ TARGETS=zlib
+ TARGETS=zlib
+ BUILD_FLAGS=--ignore-disabled
+ export TOOLCHAIN
+ export NACL_ARCH
+ export BUILD_FLAGS
+ NACL_ARCH=x86_64
+ TOOLCHAIN=glibc
+ make zlib
bin/naclports install zlib --ignore-disabled
Building 'zlib' [x86_64/glibc/release]
sha1check.py: zlib-1.2.8.tar.gz verified
######################################################################
Extracting zlib-1.2.8.tar.gz
######################################################################
chdir /Developer/SDKs/naclports/src/out/build/zlib
chdir /Developer/SDKs/naclports/src/out/build/zlib/zlib-1.2.8
Initialized empty Git repository in 
/Developer/SDKs/naclports/src/out/build/zlib/zlib-1.2.8/.git/
Switched to a new branch 'upstream'
fatal: LF would be replaced by CRLF in .gitignore
naclports: Building 'zlib' failed.
make: *** [zlib] Error 1

Default and usual setting of git config autocrlf is to 'input' on OSX (at least 
on my development machines) - however, it seems naclports requires 'false' - 
however, I seem only able to set this behavior globally which is not desired.

What version of the product are you using? On what operating system?

Nacl SDK / Pepper 35, OSX 10.9.4

Please provide any additional information below.

Original issue reported on code.google.com by hartmut on 3 Jul 2014 at 9:14

GoogleCodeExporter commented 9 years ago 
I can't reproduce this on my 10.9 system.

There should be no need for autocrlf setting in the git repos used by naclports.

The .gitignore file is created in the build_tools/common.sh script using this 
simple command: 
  echo "/build-nacl-*" >> .gitignore

There should no no existing .gitignore file in 
/Developer/SDKs/naclports/src/out/build/zlib/zlib-1.2.8.

Please reopen if you can still reproduce this.

Original comment by sbc@google.com on 30 Sep 2014 at 7:28