erikdubbelboer / fasthttp

This fork has been deprecated!
MIT License
50 stars 12 forks source link

Changed string() to b2s() in return statements #30

Closed dgrr closed 6 years ago

dgrr commented 6 years ago

Solves https://github.com/erikdubbelboer/fasthttp/issues/28 question.

erikdubbelboer commented 6 years ago

I don't think I can accept this pull request. Right now the return value of these functions will still be valid even the request. After this pull request the returned string by these functions is not mutable anymore and will change with the next requests. This means any code currently depending on these strings being mutable will break.

dgrr commented 6 years ago

You are right. Sorry