erincatto / box2d

Box2D is a 2D physics engine for games
https://box2d.org
MIT License
8.36k stars 1.55k forks source link

Redefinition of _CRT_SECURE_NO_WARNINGS macro #800

Closed DDeimos closed 2 months ago

DDeimos commented 2 months ago

Hi! There are several sources with #define _CRT_SECURE_NO_WARNINGS. I believe there should be #ifdef first for projects which have already defined the macro. In my case I get a lot of warnings because I defined the macro in my project settings to suppres GLFW warnings. I could workaround it, but I think that #ifdef would be better in any case.

erincatto commented 2 months ago

Fixed in #804