Double Step in Voted Perceptron

eriq-augustine / psl

The PSL software from the LINQS lab.

Apache License 2.0

4 stars 7 forks source link

Double Step in Voted Perceptron #65

Closed eriq-augustine closed 7 years ago

eriq-augustine commented 7 years ago

On line 279 of VotedPerceptron.java, we take a step: weight += currentStep. However, at the end of line 278 there is a hidden weight += currentStep (a semicolon appears before it ending the line and then there is a semicolon after it).

https://github.com/eriq-augustine/psl/blob/develop/psl-core/src/main/java/org/linqs/psl/application/learning/weight/maxlikelihood/VotedPerceptron.java#L278

(Caught by Qifang Zhao)

eriq-augustine commented 7 years ago

Fixed in 43ef6102202fd68e198368ed47df0d711fbaeb18.