eriwen / gradle-js-plugin

Gradle plugin for working with JS
http://eriwen.github.io/gradle-js-plugin
Apache License 2.0
382 stars 113 forks source link

Getting error with using jshint with gradle js plugin #135

Open karambirsingh opened 8 years ago

karambirsingh commented 8 years ago

I am using - com.eriwen:gradle-js-plugin: 2:12 com.eriwen:gradle-css-plugin:2.12 My Gradle version is : 2.14.1

js and css plugin is not available in mavenCentral as well as bintry. How to get updated plgin, please suggest or there is some other way around to get it build buing 2.12 js and css plugin.

BUILD FAILED

karambirsingh commented 8 years ago

I was able to download both js and css plugin using below config -

maven { url "https://repo1.maven.org/maven2/" }

But now it giving another issue, while building any ui project. My ui project don't have any direct dependencies on CompilerOptions i.e. closure-compiler.xxxxx.jar

Caused by: java.lang.NoClassDefFoundError: com/google/javascript/jscomp/CompilerOptions at com.eriwen.gradle.js.JsPlugin.apply(JsPlugin.groovy:38) at com.eriwen.gradle.js.JsPlugin.apply(JsPlugin.groovy)

eriwen commented 8 years ago

These NoClassDefFoundErrors are very unexpected. I'm afraid I can't reproduce the problem without a code sample. Would you please explain how you're using the plugins?

karambirsingh commented 8 years ago

I resolved this problem by putting required JARs on classpath like below -

buildscript { dependencies { . . . classpath (group: "com.google.javascript", name: 'closure-compiler', version: XXX) classpath (group: "com.yahoo.platform.yui", name: 'yuicompressor', version: XXX) }}

This problem is only with gradle 2.14, till 2.13 I was not required to put closure-compiler and yuicompressor on classpath.

Can you please explain why it is so? And how it was working till 2.13 version.

neodevelop commented 7 years ago

For the record! Be careful using sdkman, when grails is calling gradle you must be sure that you're calling gradle 3.0+ and if you're using the defaults in sdkman maybe cause the title's error.

Regards

eriwen commented 6 years ago

I suspect that upgrading to gradle-js-plugin v2.14.1 should resolve the issue. If not, please let me know.