erkyrath / lectrote

The IF interpreter in an Electron shell
Other
248 stars 28 forks source link

Followup changes for Glk API modernization #128

Open erkyrath opened 3 years ago

erkyrath commented 3 years ago

These follow the changes in https://github.com/erkyrath/glkote/issues/46 , https://github.com/erkyrath/quixe/issues/48 .

Quixe and InkJS are fully updated to the new format.

ifvms.js (Z-code) has been patched to deal with the new format, but needs some upstream changes. Then we can clean up the patches. See: https://github.com/curiousdannii/ifvms.js/issues/79

The emglken VMs have not been updated. They still load ifvms/gi_load.min.js, which is the old GiLoad. ifvms/gi_load.min.js should be updated to the new gi_load.js, and then the emglken interpreters updated to match the new method names. I'm not sure what's involved in that.

curiousdannii commented 3 years ago

For Emglken I'd suggest also patching prepare->init in formats.js. I think gi_load should be ready to update then. I can rename prepare in emglken in the future when I'd be doing more than a semver patch update.

Edit: formats.js already has a patch around Emglken's weirdness. I think what it needs is a line that says vm.init = function(){}.

Btw, just in case you missed it, for fixing save/restore in TADS I'm held up on https://github.com/erkyrath/remglk/pull/36#issuecomment-749399714