search

erkyrath / lectrote

The IF interpreter in an Electron shell
Other
248 stars 28 forks source link

[Windows] App doesn't quit after trying to load a corrupt file #135

Closed curiousdannii closed 2 years ago

curiousdannii commented 3 years ago

I tried to open a gblorb that was corrupt, which puts up a "Could not recognise game file" message.

But then when I try to run Lectrote.exe directly, it puts up this error. Which I now realise is the same as #131. So the real problem is that the app stays running in the background instead of quitting when it couldn't load a corrupt file.

screenshot of error

erkyrath commented 3 years ago

Staying live in the background might not be desirable, but it shouldn't cause problems.

I take it that the fix I put in March 6, trying to skip over the --allow-file-access-from-files argument, didn't work?

curiousdannii commented 3 years ago

Ah, not sure. Is it in 1.4.0?

(It does feel like an anti-pattern in Windows though, if there isn't at least an icon in the notifications area.)

erkyrath commented 3 years ago

Yes, it's in 1.4.0. Drat.

I'll take a look at the notification-icon API for Windows.

curiousdannii commented 2 years ago

I don't know if this is related, but I'm getting the "Could not recognise game file" error when opening a non-corrupt TADS 3 file. It works when opened directly from "open game" link on the launcher.

Edit: Actually this is only because Windows file associations were using an old version of Lectrote. It works in Lectrote 1.4.0.

erkyrath commented 2 years ago

I've added a tray icon on Windows. Right-clicking brings up a menu with a Quit option.

erkyrath commented 2 years ago

I think the --allow-file-access-from-files error is gone, so I'm marking this done.