erlangpack / bcrypt

Erlang wrapper for OpenBSD's Blowfish password hashing code
https://hex.pm/packages/bcrypt
Other
16 stars 19 forks source link

Add Pooling for NIF and Bugfix for erlang.mk port build #6

Closed elanfs closed 4 years ago

elanfs commented 5 years ago

I encountered issues where port program doesn't build correctly when using erlang.mk (for otp 20.3.8.x ) i suspect due to using the -shared flag for both .so and port exe

Also added pooling for NIF because its a bottleneck (only uses one thread/genserver)

mworrell commented 4 years ago

@elanfs Could you please rebase on top of the current version?

elanfs commented 4 years ago

Hello @mworrell, I did the rebase as needed.

Ommited commits with C flags changes, since it works without issues with erlang.mk

mworrell commented 4 years ago

Thanks! Will review and include your work in the 1.1.0 version.