search

erlangpack / bcrypt

Erlang wrapper for OpenBSD's Blowfish password hashing code
https://hex.pm/packages/bcrypt
Other
16 stars 19 forks source link

Fix linking on newer SmartOS versions #7

Closed siepkes closed 4 years ago

siepkes commented 5 years ago

Newer SmartOS versions require the 'xnet' library to be explicitly declared to the linker. While this might not be needed on plain Solaris this is good form non the less (since bcrypt uses symbols from the net library).

sundbry commented 4 years ago

I came across this issue on the latest stable OmniOS (Illumos) using gcc9 where 1.0.2 is also unable to build. Confirming that this patch resolves the linker problem. Looks Good To Me! cc @ddeboer

ddeboer commented 4 years ago

Thanks for the fix @siepkes and thanks for confirming @sundbry! Tagged as 1.0.3.

mworrell commented 4 years ago

@ddeboer shall we just remove the "deploy" from the build and make it manual. Now it looks as if the build was broken in this change (it was not).