erlangpack / bcrypt

Erlang wrapper for OpenBSD's Blowfish password hashing code
https://hex.pm/packages/bcrypt
Other
16 stars 19 forks source link

Rename function to avoid clash with OpenBSD's native bcrypt. #8

Closed hoosiersoft closed 4 years ago

hoosiersoft commented 4 years ago

OpenBSD provides its own declaration for function bcrypt in pwd.h. This conflicts with the changes introduced in commits 1277ee41bba86d47e039e3f24a47a491efe48d78 and ce7523f34b9b2b18c76490ffbb832a54603f7a55.

Renaming the function to "ts_bcrypt" ("thread safe bcrypt") avoids this. Additionally, in bcrypt_port.c, the return type was still the original char *, changed this to type int to match the function definition in bcrypt.c.

mworrell commented 4 years ago

Thanks!

mworrell commented 4 years ago

(And sorry for the delay...)