Fix DPoP with JWK Set - Githubissues

erlef / oidcc

OpenId Connect client library in Erlang & Elixir

https://hexdocs.pm/oidcc

Apache License 2.0

183 stars 49 forks source link

Fix DPoP with JWK Set #346

Closed maennchen closed 6 months ago

maennchen commented 6 months ago

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 172

Details

8 of 11 (72.73%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 92.354%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/oidcc_authorization.erl	2	3	66.67%
src/oidcc_jwt_util.erl	5	7	71.43%
<!--	Total:	8	11	72.73%	-->

Totals
Change from base Build 169:	-0.06%
Covered Lines:	1063
Relevant Lines:	1151

💛 - Coveralls

maennchen commented 6 months ago

@paulswartz I assume this is because "use": "sig" is not set on the JWK you're using.

(I used this key to test conformance: https://github.com/erlef/oidcc_conformance/blob/f3c773576607ef5090328d7f2608a14496b480c5/artifacts/client.priv.jwkset)