Closed wojtekmach closed 1 month ago
@paulo-ferraz-oliveira @starbelly thank you for the feedback. Regarding https://github.com/jelly-beam/otp-macos, it is quite comprehensive and it's a great starting point. Now that you can see how I tried implementing this, we can consider the next steps.
Would you rather:
?
Would you rather:
"merge changes from jelly-beam/otp-macos here", for me 👍
Some stuff can be adapted, I guess, but only if there's a need for it; as long as we have the builds here there's only a few details I'd update, but I don't think they'll change the base behaviour:
.txt
- or maybe the dispatch already does it?): important in case we want to update e.g. OpenSSL without disruption.sha256.txt
of the result next to it, for security #25 This said, I'd go with your current implementation; it's a good starting point and I can see a couple of advantages:
brew
ing it),kerl
ing it),kerl
so it's possible it's not working, but it's better to have it, too)I'm also Ok with using otp-macos
but it'd need some issues taken care of (remove brew
and kerl
, for example; add wxWigets), so it's less relevant here.
This said, I'd go with your current implementation; it's a good starting point and I can see a couple of advantages:
* compiling OpenSSL (instead of `brew`ing it), * doing all stuff by hand (instead of `kerl`ing it), * using wxWidgets (I didn't test that as a default for `kerl` so it's possible it's not working, but it's better to have it, too)
I'm also Ok with using
otp-macos
but it'd need some issues taken care of (removebrew
andkerl
, for example; add wxWigets), so it's less relevant here.
☝️ That. Let's go with this PR, then roll in changes that were done in otp-macos, collaboratively.
Sounds good, I’ll send some updates here soon!
@wojtekmach Just to confirm, you are ready for this to be merged?
Not quite yet, I'll merge this myself if that's OK.
I have made the following changes:
macos-{amd64,arm64}
to {x86_64,aarch64}-apple-darwin
in filenames. The rationale was we'd match erlang:system_info(system_architecture)
. I'm going to keep build artifacts using old names for a while since beamup
was already using this project.builds/*.txt
to builds/*.csv
and added openssl and wxwidgets versions there.I'm going to merge this as is to unblock others tasks but please feel free to keep the discussion going here or in other issues.
Thanks everyone for reviewing this!
This is the implementation of the OTP macOS builds proposal.
Updated README.md: https://github.com/erlef/otp_builds/blob/wm-initial/README.md
As you can see in commits list, the GitHub job automatically commits
builds/*.txt
changes.Builds can be manually triggered like this:
Example