erosDiffusion / ComfyUI-enricos-nodes

Compositor Node experiments
MIT License
313 stars 10 forks source link

Node unresponsive after editing canvas again #45

Closed sky958958 closed 2 months ago

sky958958 commented 2 months ago

hi~ Encountering a very strange problem, the first queue was successful, But when I am not satisfied with the composition, I adjust the canvas and move the zoom, but the nodes cannot run again, the borders are red, and there is no response operation

erosDiffusion commented 2 months ago

it might have to do with an older node definition as v2 introduced some regressions but workarounds are possible (i'm rewriting the node again to fix the regressions)

if that does not works and

i'm talking of v2 a screenshot and developer tools open (F12 and show the console tab) might help understand what's going wrong

sky958958 commented 2 months ago

Hello, if you move the position again, the queue will not work properly image image

erosDiffusion commented 2 months ago

so, i see some nulls in plugins and that index.js line 381 as red

if that does not help:

let me know how it goes ;)

if you know how to debug, maybe click on that index.js 281 red line and show me it has anything to do with compositor. you can also give me the flow but i see it's pretty simple.

erosDiffusion commented 2 months ago

@sky958958 so I did a quick check it seems impact pack is searching for something in my custom node events -> output.aux

function progressExecuteHandler(event) {
    if(event.detail.output.aux){
        const id = event.detail.node;
        if(input_tracking.hasOwnProperty(id)) {
            if(input_tracking.hasOwnProperty(id) && input_tracking[id][0] != event.detail.output.aux[0]) {
                input_dirty[id] = true;
            }
            else{

            }
        }

        input_tracking[id] = event.detail.output.aux;
    }
}
sky958958 commented 2 months ago

The first queue was successful, but there was no response after only moving the canvas and queuing againimage workflow - 2024-09-13T211729.070.json

erosDiffusion commented 2 months ago

@sky958958

note: in this version there is actually a bug that if the image does not change it will still re-render, I'm rewriting the plugin so that it does not happen. the new vesion is in pr #37 but not ready for releasing

sky958958 commented 2 months ago

Looking forward to your update~Your node is really cool and convenient. Keep me away from those troublesome numerical settings

erosDiffusion commented 2 months ago

did it not work by disabling impact pack ?

to recap, I've also had some wierd behavior when you get a red line, re enqueue again until it goes :) it fixed it for me.

in short, re-enqueue after it breaks until it goes , second or third time it gets it :D

sky958958 commented 2 months ago

Even if the impact package is disabled, the same problem will still occur. Now, the storetranorms button must be triggered back and forth to queue

erosDiffusion commented 2 months ago

I see, leave defaults on there should be no need to change them, when you get the red line, just push the enqueue button multiple times.

i hope this helps, sorry for the bad quality https://github.com/user-attachments/assets/d0bb351c-6fa8-4dcb-8f4c-9aeae949d53a

sky958958 commented 2 months ago

image I don't understand technology, but I have an idea. For example, after adjusting the canvas, there is a control button below that can be clicked to directly trigger the subsequent workflow

sky958958 commented 2 months ago

You have done an excellent job, it just takes time to maintain it. This node is the most anticipated one I have ever used

erosDiffusion commented 2 months ago

image I don't understand technology, but I have an idea. For example, after adjusting the canvas, there is a control button below that can be clicked to directly trigger the subsequent workflow

in the new version it will come a button like "continue", that does what you ask. I'm working on a wait function that's controlled by pause.

so when you pause the capture will read "continue" (technology wise continue is making the waiting thread move) while enqueue is re-submitting a slightly changed flow that's being stopped (old nodes dont' execute as they are cached)

pr #37 is a rewrite to solve the issues with inconsistent behaviur regarding execution. i'm almost finished but i will not be able to work on it in the weekend :D

sky958958 commented 2 months ago

Thank you for your video demonstration. Looking forward to your follow-up updates~Have a nice weekend~

erosDiffusion commented 2 months ago

should be fixed with v3 in pr #46