ersilia-os / 3d-analogues

Evaluation of analogues in the 3D Space
GNU General Public License v3.0
0 stars 0 forks source link

Python packaging & repo structure #1

Open GemmaTuron opened 3 months ago

GemmaTuron commented 3 months ago

Hi @miquelduranfrigola

As this is organised now, it basically uses three modules:

Q1: since both smiles-to3d and vsflow-... are very small repos, is this the right structure or we should embed the code within THIS repository?

Q2 (maybe for @DhanshreeA ) I've given up on the python packages. Both repositories, smiles-to-3d and vsflow-ersilia have a setup.py and in principle should be pip installable from the repo, but unless I clone the repo and do pip install . from the cloned repos it does not work, what am I doing wrong?

miquelduranfrigola commented 3 months ago

Hello @GemmaTuron

RE:

DhanshreeA commented 3 months ago

@miquelduranfrigola I'd spent some time on this last week and it's not about package data, for some strange reason, Python is unable to find the installed module (smiles3d). The only way we could get it to work was going from the src layout to flat layout.

miquelduranfrigola commented 3 months ago

Oh OK, so is it solved?

GemmaTuron commented 3 months ago

mmm not really I think

I've added the necessary code from VSFlow so we only need to make sure smiles-to-3d is pip installable

miquelduranfrigola commented 3 months ago

all right. let's have a look together and make smiles-to-3d pip-installable