search

ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
210 stars 143 forks source link

🐈 Task: Inconsistency between current licenses recognized by Ersilia vs those maintained in Airtable #1188

Closed DhanshreeA closed 2 months ago

DhanshreeA commented 3 months ago

Summary

We recently modified acceptable model licenses to be in SPDX format however this has introduced two bugs that drastically affect the model incorporation workflow:

  1. Previously incorporated models cannot be successfully edited now, should the need arise, because Ersilia does not recognize those models as having a correct license.
  2. Airtable does not have licenses in the SPDX format, so newer models are not accepted by our workflows because Airtable rejects these license identifiers.

The solution here is two fold, and partly stop gap. We will do the following:

Objective(s)

The first task can be easily achieved by taking content from the license.txt file ersilia/hub/content/metadata from a commit before this PR was merged. As for the second task, we can either do it manually or through a GitHub action can be implemented to update Airtable with this data, this action is dispatched only when the license.txt file is modified.

Documentation

No response

DhanshreeA commented 3 months ago

@GemmaTuron tagging you in this issue for the second task.

GemmaTuron commented 3 months ago

Hi @DhanshreeA Can you confirm if you want me to delete the old license information and switch for the new one? I thought that is what we decided but now looking at point 1 is like we want to keep the old licenses as well?

miquelduranfrigola commented 2 months ago

That would be ideal, @GemmaTuron - let's just be extra careful with back-compatibility with old models.

GemmaTuron commented 2 months ago

I thought we said we would just use new ones @miquelduranfrigola ?

DhanshreeA commented 2 months ago

Note: As a stop gap, intermittent solution, we decided to maintain both older formats of licenses and the newer format - however we will deprecate the older versions in the future.