esaulenka / ghidra_v850

Ghidra support for Renesas V850 MCUs
MIT License
60 stars 25 forks source link

Fix st.w storing only half-word #31

Closed pd0wm closed 2 months ago

pd0wm commented 2 months ago

One of the two st.w variants would only store 2 bytes instead of 4. This would lead to weird SUB42() in the decompilation.

Same bug is present upstream: https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Processors/V850/data/languages/Instructions/Load_Store.sinc#L210

2024-04-30-130752_641x920_scrot

esaulenka commented 2 months ago

oh, it's just silly copypaste error thanks for fix!