search

escalier-lang / escalier-next

Improved type safety with tight TypeScript interop
https://escalier-lang.github.io/escalier-next/
MIT License
14 stars 0 forks source link

Update inferBlock to use inferTree et al. #264

Closed kevinbarabash closed 4 months ago

kevinbarabash commented 4 months ago

This PR updates inferBlock (which infers function bodies, if/else blocks, etc.) to use the same internals as inferModule and after a few minor tweaks (around when to generalize or not) all the tests are passing. There are still some test cases that using inferScript that will need to be migrated over to inferModule, hopefully I don't run into too many issues with that. I'll tackle that in a followup PR.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 69.23077% with 28 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (f029074) to head (ca6ecec).

Files Patch % Lines
src/Escalier.TypeChecker/Infer.fs 70.78% 26 Missing :warning:
src/Escalier.TypeChecker/Unify.fs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ========================================== - Coverage 84.05% 83.75% -0.30% ========================================== Files 23 23 Lines 10534 10599 +65 Branches 1501 1516 +15 ========================================== + Hits 8854 8877 +23 - Misses 1680 1722 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.