search

esedaghatnejad / psort

P-sort is an open-source, Python-based, cross-platform software with an intuitive GUI. It has been designed to address the challenges of cerebellar neurophysiology, specifically, sorting cerebellar Purkinje cells.
GNU General Public License v3.0
11 stars 2 forks source link

Compatibility issues with Matlab 24.1.0.2653294 (R2024a) Update 5 #11

Open shafiei-masih opened 1 month ago

shafiei-masih commented 1 month ago

/psort/matlab_codes/Psort_read_psort.m

line28 | file_info = hdf5info(file_fullPath); -> issue: MATLAb recommends using the new "h5info" instead of "hdf5info". With the "hdf5info", Matlab crashes when trying to run line 28. -> fix: file_info = h5info(file_fullPath);

line 29 | file_info = file_info.GroupHierarchy; line 42 | variable_name = variable_name(length(slot_name)+2:end); line 61 | variable_name = variable_name(length(slot_name)+2:end); -> issue: as the "h5info" function's output structure is different from the "hdf5info", some of the command lines related to file_info needs to be changed. -> fix: comment out lines 29, 42 and 61.

esedaghatnejad commented 1 month ago

Thanks for the report @shafiei-masih

Unfortunately, I no longer have access to Matlab, so I cannot check this directly. Having said that, I am surprised to hear that Matlab crashed with a legacy command. I can see that the usage of hdf5info is not recommended anymore, but it is not deprecated yet. So, I am inclined to use hdf5info till it gets deprecated.

esedaghatnejad commented 1 month ago

I will keep this ticket open to see if it is a common problem for others as well.