esenliyim / sp-tray

Gnome extension to display spotify metadata
GNU General Public License v3.0
55 stars 22 forks source link

[Feature Request] Text in paused field is not able to show {album} | {track} #30

Closed peterge1998 closed 2 years ago

peterge1998 commented 2 years ago

Hey, I love your extension and its customizeability. One thing I am missing is to show the {album} | {track} even if playback is stopped.

A toggle to enable showing during stopped could solve this too.

Otherwise, if i paste in {artist} | {album} | {track}, only {art is shown during stopped playback: image

esenliyim commented 2 years ago

Is #25 what you mean?

peterge1998 commented 2 years ago

Yes, thats basically the same. However, i describe how this can be controlled by 2 different ways, but feel free to close this if you think my issue is unecessary.

esenliyim commented 2 years ago

So I understand you want to have a separate metadata display format for the paused text, is that correct?

peterge1998 commented 2 years ago

Hi @esenliyim, thanks for looking for this. These are the 2 posibilities i could imagine to solve this: 1.) Allow more than 4 character in "Paused" field and make {artist} | {album} | {track} work when paused, so the track info shows the whole time regardless playback is stopped 2.) Add a toggle button, to show the paused text if paused or the opposite (depending on what you want to show by default). Then the logic behind this toggle button that it does not show "Paused" text, or the opposite.

Is my description understandable? Feel free to ask if not

esenliyim commented 2 years ago

I'm not quite understanding how what I've done for #25 isn't doing what you're describing.

Track info can already be shown when paused. That's what the {metadata} placeholder is for. When you include it in the paused field, it shows the track info when paused. You can't set the metadata to be shown differently in the paused field though, it uses the format you've defined for normal playback.

What am I missing?

peterge1998 commented 2 years ago

Oh, great, that seems to do excatly what i want. However, i can just insert {met into the "Paused" field, I guess this is because of an old version on extensions.gnome.org, which i am using. Do you have any plans to update it on extensions.gnome.org?

THANKS!

esenliyim commented 2 years ago

Yes, that's exactly why you can only type in 4 characters. That's the limit on the current version on extensions.gnome.org, the newer versions have a much higher character limit.

I'll be uploading the most recent version once I've fixed this one problem I've been working on. In the meantime you can manually install it by cloning this repo and running the install script.