eshaham / israeli-bank-scrapers

Provide scrapers for all major Israeli banks and credit card companies
MIT License
600 stars 163 forks source link

CAL scraper failed in new website #793

Open niv280 opened 1 year ago

niv280 commented 1 year ago

Hi, I'm getting Timeout error while using visacal scraper. It's look that the error happened inside getLoginFrame, when the scraper don't found the login frame.

I'm not got good knowledge in scraping but it's seems to me that visa cal update their website, and when I tried to use the scraper with showBrowser it's look that there is some kind of popup window that might block the scraper from moving on to the transactions area.

baruchiro commented 1 year ago

VisaCal is working well for me

niv280 commented 1 year ago

That can be different between different users?

galbarm commented 1 year ago

Maybe different OS? for me this is working well on Windows

niv280 commented 1 year ago

I'm running it in ubuntu, do you think that can cause problems? I remember now, that visa cal worked for me in windows when I used Caspion a while ago

JuloWaks commented 1 year ago

I also have this issue, it seems to be casued by this banner:

Screenshot 2023-07-10 at 16 59 13

I tried accepting the banner on a different browser, but it sill appears. Scrapper fails with error:

scraping Visa Cal
Visa Cal: START_SCRAPING
Visa Cal: INITIALIZING
Visa Cal: LOGGING_IN
Visa Cal: TERMINATING
Visa Cal: END_SCRAPING
success: false
error type: TIMEOUT
error: wait for iframe with login form
Error: wait for iframe with login form
    at scrape (/Users/jwaksberg/YNAB/israeli-ynab-updater/src/scrape/scrape-base.js:67:11)
baruchiro commented 1 year ago

I tried to close this banner here: https://github.com/eshaham/israeli-bank-scrapers/blob/2f9d73638b641c2c770f104a7887f7db12800cee/src/scrapers/visa-cal.ts#L296-L306

gczobel commented 1 year ago

The same happens to me today, running on ubuntu. I entered the website in my browser and a change password was required (that was not detected by the scraper). After that, the same screen about the new website was displayed... so probably a combination of the two?

github-actions[bot] commented 1 week ago

Issue has been marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.