esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
207 stars 23 forks source link

EVE v20.10 - Faction Warfare Advantage #1335

Open soratidus999 opened 1 year ago

soratidus999 commented 1 year ago

Feature Request

EVE 20.10 Added advantages to system, this is seperate to sovereignty contest, but has a scaling effect on those mechanics. https://www.eveonline.com/news/view/patch-notes-version-20-10#advantage

Since this data is more than just a single flag on a system, it probably needs a new endpoint.

It would be quite clunky to add ?six? fields to the existing https://esi.evetech.net/ui/#/Faction%20Warfare/get_fw_systems

Use case

Generating better maps of Faction Warfare and presenting them to the public outside of the game, as we do currently. But these maps will now be missing crucial data.

Authentication

No changes required, this is simply to replicate features that were created on TQ to their assocated endpoints

Example return

Replicate the data presented to the client, for all systems very similar to /fw/systems https://i.imgur.com/8ciraDk.png

[
  {
  "solar_system_id": 30002957,
  "advantage_data": [
    {
      "faction_id": 500001,
      "completed_objectives": 20
      "neighbouring_systems": 10
    },
    {
      "faction_id": 500002,
      "completed_objectives": 60
      "neighbouring_systems": 30
    }
    ]
  },
  ... repeat ad absurdium
]

Checklist

Check all boxes that apply to this issue:

IcyMidnight commented 1 year ago

This would be better to bake into the existing endpoint. Almost anyone who queries the current endpoints will want this data so we'd just be turning one request into two unnecessarily.

soratidus999 commented 1 year ago

Advantage is being published here https://www.eveonline.com/api/warzone

IcyMidnight commented 1 year ago

Oh! Nice spotting! Looks like that is what the newly introduced interface at https://www.eveonline.com/frontlines is using as a source.

I guess https://www.eveonline.com/api is for "internal" CCP APIs so we can't rely on it, but we could use it for now. Also looks the frontlines page pings it every 30s or so and at a very brief glance it seems to update approx. every 5 minutes unlike the approx. every 30 minutes of the current ESI API.