esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

/characters/{character_id}/notifications/ - unknown notification type (6013) #1392

Open soratidus999 opened 1 month ago

soratidus999 commented 1 month ago

Bug

Regression of https://github.com/esi/esi-issues/issues/1380 which is a regression of https://github.com/esi/esi-issues/issues/1368

A notification returned from /characters/{character_id}/notifications/ is not returning it's type, instead they are returning an "unknown notification type (6013)" breaking validation of this response data. Interfering with the normal usage of this endpoint.

This is occuring because the respective notification types have not been added to eve-glue. These notifications should not neccessarily be in eve glue because they are part of the 6xxx ephemeral range and are supposed to be client only.

I am fairly certain this is Daily Reward Auto-Redeemed, after looking in the notifications test menu manually. But i do not have the Class.

Request

GET http://characters/character_id/notifications/?datasource=tranquility

Response

Status Code

200

Headers

I didnt record headers this time around

Body

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "station_id: 1234567890 type_id:12345",
    "timestamp": "2024-08-31Txx:yy:00Z",
    "type": "unknown notification type (6013)"
  },
...

Expected

200

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "station_id: 1234567890 type_id:12345",
    "timestamp": "2024-08-31Txx:yy:00Z",
    "type": "DailyRewardAutoRedeemed" ?? Guessing at the Class ??
  },
...

Checklist

Check all boxes that apply to this issue: