Enhancements - Githubissues

esoxjem / MovieGuide

Movie discovery app showcasing MVP, RxJava, Dagger 2 and Clean Architecture

MIT License

2.61k stars 857 forks source link

Enhancements #95

Closed KaveriKR closed 5 years ago

KaveriKR commented 5 years ago

Few enhancements made :

Added swipe refresh button to load the movies again dynamically without reopening the app. Useful in case when application is opened with blank screen in case of no internet.
Replaced deprecated Butterknife.findById with the android findViewById.
Added a play button on the trailers video layout to denote playable option. .

esoxjem commented 5 years ago

@KaveriKR there seems to be a build error

Output:  /bitrise/src/app/src/main/res/values-v21/styles.xml:37:5-90: AAPT: error: 
resource transition/explode (aka com.esoxjem.movieguide:transition/explode) not found.

KaveriKR commented 5 years ago

Thank you for pointing the error.

esoxjem commented 5 years ago

Also, please create separate PRs for each issue

KaveriKR commented 5 years ago

Also, please create separate PRs for each issue

have updated