search

esp-rs / esp-idf-template

A "Hello, world!" template of a Rust binary crate for the ESP-IDF framework.
372 stars 43 forks source link

Add workaround for #174, cc crate failing on macOS #208

Closed sirhcel closed 1 month ago

sirhcel commented 1 month ago

I've hit this trap several times during the last weeks. #174 describes it and the solution. But every time I hit it, I just had forgotten about it which was quite annoying.

The workaround apparently does not affect Linux (while I can't test on Windows). So why not shipping it until #174 gets resolved and released.

Vollbrecht commented 1 month ago

Yeah for the current time it seams to be the best option.

ivmarkov commented 3 weeks ago

@sirhcel This PR is mentioning https://github.com/esp-rs/esp-idf-hal/pull/387 but I think this link is completely unrelated to the issue at hand. Isn't it?

sirhcel commented 3 weeks ago

Yes, https://github.com/esp-rs/esp-idf-hal/pull/387 is unrelated. I misread https://github.com/esp-rs/esp-idf-template/issues/174#issuecomment-1984193670 in the first place. Thank you for spotting this @ivmarkov! Fixed the description here.

ivmarkov commented 3 weeks ago

Thank you for spotting this @ivmarkov! Fixed the description here.

Where is "here"?

sirhcel commented 3 weeks ago

Where is "here"?

The description of this PR (#208). I see that the hint somewhat hidden as (edited) in the top bar of https://github.com/esp-rs/esp-idf-template/pull/208#issue-2283138034 and I should have stated this more clearly in the first place. 😅

ivmarkov commented 3 weeks ago

The problem is this line in the (now merged) PR, as it is mentioning a completely unrelated issue.

So potentially anybody who is generating a new project will have this wrong comment in his .config/cargo.toml and might get confused.

Would you create a mini-PR removing the reference to the completely unrelated issue?