Overhaul of GPIO module & adjusted Serial module accordingly.

esp-rs / esp32-hal

A hardware abstraction layer for the esp32 written in Rust.

Apache License 2.0

192 stars 28 forks source link

Overhaul of GPIO module & adjusted Serial module accordingly. #36

Closed arjanmels closed 4 years ago

arjanmels commented 4 years ago

Renamed GPIO and RTC_IO register field to strip common prefix.
Fixed bugs in GPIO
Simplified GPIO code

TODO:

Add support for routing
Add support for additional configuration (e.g. pullup/down, drive strength, etc.)

This depends on https://github.com/esp-rs/esp32/pull/34 and it builds on #34.

Addresses issue #35 and #19

arjanmels commented 4 years ago

Changed this to WIP so I can include more changes in one go.

arjanmels commented 4 years ago

@MabezDev and @chocol4te I think this is in pretty good shape now. Your review and feedback is most welcome. (Todo's are intterrupt handling and perhaps some more functionality on the RTC_MUX.)

(I also updated the i2c to teh latest version: https://github.com/arjanmels/esp32-hal/tree/feature-i2c-am

arjanmels commented 4 years ago

Just some really small comment/formatting changes suggested, looks really solid and can't think of anything to change in the implementation!

Thanks, always nice to put the dots on the i's and cross the t's. :-)

arjanmels commented 4 years ago

In principle, I think this is ready for merge: https://github.com/esp-rs/esp32/pull/34 has been merged as well as #34. Also the problems @chocol4te was having are solved (https://github.com/esp-rs/esp32-hal/pull/26#issuecomment-648833861).

However, I could still add interrupt support and more extensive support for the RTC IO mux. I will be working on this over the next day/weekend; I can merge it in this PR or can make a new one.

fmckeogh commented 4 years ago

@arjanmels imho it might be slightly easier to merge this and have separate PRs for the additional functionality, but I’m also happy to just rebase against this branch when I finish up the I2C work :)