Minor simplification of xtensa targets.

esp-rs / rust

Rust for the xtensa architecture. Built in targets for the ESP32 and ESP8266

https://www.rust-lang.org

Other

743 stars 39 forks source link

Closed KerryRJ closed 3 years ago

KerryRJ commented 3 years ago

Tripple in the target replaced by xtensa. Move unsupported_abi to an xtensa_base much like the arm targets.

KerryRJ commented 3 years ago

I am unsure as to why these checks are failing.

MabezDev commented 3 years ago

I am unsure as to why these checks are failing.

The runners are part of the rust-lang org, and will not run on forks hence the failure.

MabezDev commented 3 years ago

Can we also simplify it further? panic_strategy, relocation_model, emit_debug_gdb_scripts are the same between all targets I think.

KerryRJ commented 3 years ago

Can we also simplify it further? panic_strategy, relocation_model, emit_debug_gdb_scripts are the same between all targets I think.

I'll take a look.

KerryRJ commented 3 years ago

Further simplifications implemented.

MabezDev commented 3 years ago

Thanks, the changes look great! Would you mind rebasing on top of the current esp branch?

MabezDev commented 3 years ago

Thank you @KerryRJ!