espressif / esp-usb

Other
29 stars 16 forks source link

cdc-ncm ethernet speed hardcoded (IEC-175) #69

Open chegewara opened 1 month ago

chegewara commented 1 month ago

Answers checklist.

General issue report

Hi, since we are having now P4 with USB-HS, is it possible to update ethernet speed notification code according to upstream repo?

https://github.com/hathach/tinyusb/discussions/742

tu_static struct ncm_notify_t ncm_notify_speed_change = {
    .header = {
        .bmRequestType_bit = {
            .recipient = TUSB_REQ_RCPT_INTERFACE,
            .type = TUSB_REQ_TYPE_CLASS,
            .direction = TUSB_DIR_IN},
        .bRequest = CDC_NOTIF_CONNECTION_SPEED_CHANGE,
        .wLength = 8,
    },
    .downlink = TUD_OPT_HIGH_SPEED ? 480000000 : 12000000,
    .uplink = TUD_OPT_HIGH_SPEED ? 480000000 : 12000000,
};

Now we are having hardcoded ethernet speed 10mb/s

Thanks

tore-espressif commented 1 month ago

Yes, this is definitely on our todo list. Internally, we made only few P4+USB+network tests, but did not manage to make it public yet.

We will update this ticket when we have some news to share

chegewara commented 1 month ago

Thanks It is not that important thou. From my test I can tell it's just cosmetic value to display in OS, it doesn't impact on real transfer speed.