search

espterm / espterm-firmware

ESPTerm - ESP8266 terminal emulator. Branches: [master] patches, [work] next release
Mozilla Public License 2.0
128 stars 24 forks source link

Color triangle does not work depending on screen Y #236

Closed cpsdqs closed 7 years ago

cpsdqs commented 7 years ago

It's really strange; sometimes it works, and then you scroll down or up a bit and it hits a threshold where it just doesn't do anything when you click and drag. Tested in Safari. Also what is that sorcery—SVG with a pixelation filter or something? xD It can't be inspected, it excuses itself and disappears when you open dev tools :(

MightyPork commented 7 years ago

yeah it's somewhat buggy - I've converted the library to ES6, but the bugs survived apparently (if not multiplied)

i think it's not doing a v good job at figuring out the relative mouse coordinate

MightyPork commented 7 years ago

oh and it's a canvas

MightyPork commented 7 years ago

wow what a shitshow

it measures the element offset on load and then thinks it's fixed forever (?)

MightyPork commented 7 years ago

removed like 20 lines of javascript and used getboundingclientrect instead, seems to work ok