search

ess-dmsc / h5cpp

C++ wrapper for the HDF5 C-library
https://ess-dmsc.github.io/h5cpp/
GNU Lesser General Public License v2.1
116 stars 19 forks source link

Further choices for LibVersion #648

Closed FlyingSamson closed 3 months ago

FlyingSamson commented 4 months ago

Is there a particular reason for only wrapping H5F_LIBVER_LATEST and H5F_LIBVER_EARLIEST and not the remaining values of H5F_libver_t?

If not, I would be happy to add the remaining (e.g., as V110 = H5F_LIBVER_V110, etc.) and create a PR.

In my particular use case, I would for instance like to ensure large attribute support requiring a minimum of V18, but without restricting the compatibility of the written file to the version of HDF5 that happens to be installed on a system by specifying H5F_LIBVER_LATEST as upper bound.

yuelongyu commented 4 months ago

hi @FlyingSamson,

Yes, I agree. It makes sense to add those options. It will be appreciated if you create the PR.

FlyingSamson commented 3 months ago

Implemented in #649.