search

essential-contributions / essential-integration

Integration of Pint and the Essential protocol.
Apache License 2.0
4 stars 3 forks source link

feat: check submitted solution CA against attemped #132

Closed supiket closed 1 week ago

supiket commented 1 week ago 
bash-5.2$ pint deploy --builder-address http://0.0.0.0:3554
   Compiling pint [contract] (/Users/tokamak/essential/essential-integration/apps/counter/pint)
    Finished build [debug] in 2.2065ms
    contract pint            1899743AA94972DDD137D039C2E670ADA63969ABF93191FA1A4506304D4033A2
         └── pint::Increment 355A12DCB600C302FFD5D69C4B7B79E60BA3C72DDA553B7D43F4C36CB7CC0948
   Deploying pint 1899743AA94972DDD137D039C2E670ADA63969ABF93191FA1A4506304D4033A2
    Received solution address 1FD5247B6DBB3C79CA875FD54894F71F0840F38E469D5A2270BD8AE02FBF22FA
bash-5.2$ pint submit --builder-address http://0.0.0.0:3554 --solution ./solution.json
  Submitting solution 68A1BC8E7A5E6789E8DE4BC59A7ADD0BFC5AF7FA591FCC03CEBE6E4754C13CA1
   Submitted successfully

Closes #129

mitchmindtree commented 1 week ago

Maybe it would be sweet if we could also emit this from pint deploy, so that deployment looks something like:

   Deploying counter 1899743AA94972DDD137D039C2E670ADA63969ABF93191FA1A4506304D4033A2
  Submitting solution 68A1BC8E7A5E6789E8DE4BC59A7ADD0BFC5AF7FA591FCC03CEBE6E4754C13CA1
   Submitted successfully

I'm thinking it might be useful for users to see the address of the solution used to deploy their contract? And also get the same behaviour of verifying the returned solution address? Maybe we use pint-submit in pint-deploy directly somehow? Either way we could probs leave this for a follow-up issue 👌