search

esteinberg / plantuml4idea

Intellij IDEA plugin for PlantUML
Apache License 2.0
633 stars 113 forks source link

Diagram exports should not also affix the diagram title in the file name #355

Open ParadoxV5 opened 2 years ago

ParadoxV5 commented 2 years ago

Unintuitively, plantuml4idea adds the diagram title to the file name when exporting a diagram, instead of using the file name chosen in the export window.

For example, create a .puml file with the following content:

@startuml
title bar
@enduml

Exporting this file to foo.svg will instead create the file named foo-bar.svg.

krasa commented 2 years ago

disablig this should help image

ParadoxV5 commented 2 years ago

disablig this should help image

Huh, thanks for pointing that out. If this option is off by default, then I must’ve checked it thinking that it populates the default export file name with the diagram title (e.g., bar.svg) (instead of adding the diagram title to the file name I specified). I’m slightly wondering what’s the purpose of this option existing.

krasa commented 2 years ago

Afaik it is enabled by default https://github.com/esteinberg/plantuml4idea/issues/270

ParadoxV5 commented 2 years ago

Afaik it is enabled by default #270

The message for the commit (0544a02) that closes it:

(enabled by default)

I must’ve left it checked with the thought process as above.

ParadoxV5 commented 2 years ago

Shall we open a follow-up issue/PR requesting this option be unchecked by default?

ParadoxV5 commented 2 years ago

disablig this should help image

I’ve checked. Yes, disabling this is the behaviour I expected.

krasa commented 2 years ago

I think people are already accustomed to it, disabling would be counterproductive. Maybe just a better label would be enough.

ParadoxV5 commented 2 years ago

I think people are already accustomed to it, disabling would be counterproductive.

Not disabling entirely, but disabled by default, i.e., disabled for new users who have not used this plugin before (and therefore don’t have the default settings saved)

Maybe just a better label would be enough.

Perhaps a hint on the first time a user exports an image hinting them they can remove/add the graph title part to the export file name.

krasa commented 2 years ago

Not disabling entirely, but disabled by default, i.e., disabled for new users who have not used this plugin before (and therefore don’t have the default settings saved)

That would result in inconsistency across multiple IDEs and team members.