estuary / marketing-site

0 stars 5 forks source link

Fix blog post image alt text #203

Closed jshearer closed 3 months ago

jshearer commented 9 months ago

Bug The images inside of a blog post have the default alt text Blog Post image

Expected The alternative text should come from the Strapi response

Screenshots Example: Renders with the incorrect alt tag image

The text is set in Strapi image

The proper default is returned in the Body The default is returned in the childHtmlRehype image

travjenkins commented 8 months ago

Updating the component to log these fields: image

alt is undefined

[============                ]   466.903 s 1128/2611 43% Running gatsby-plugin-sharp.IMAGE_PROCESSING jobs
ImgSharpInline {
  alt: undefined,
  images: {
    fallback: {
      src: '/static/cb74adc73d621cdd2328cc6a4a2cea2b/50768/08_Data_Migration_Solution_Matillion_a69da6c438.png',
      srcSet: '/static/cb74adc73d621cdd2328cc6a4a2cea2b/1167e/08_Data_Migration_Solution_Matillion_a69da6c438.png 428w,\n' +
        '/static/cb74adc73d621cdd2328cc6a4a2cea2b/4df1e/08_Data_Migration_Solution_Matillion_a69da6c438.png 856w,\n' +
        '/static/cb74adc73d621cdd2328cc6a4a2cea2b/50768/08_Data_Migration_Solution_Matillion_a69da6c438.png 1711w',
      sizes: '(min-width: 1711px) 1711px, 100vw'
    },
    sources: [ [Object] ]
  },
  props: {
    imgdata: '{"layout":"constrained","backgroundColor":"#f8f8f8","images":{"fallback":{"src":"/static/cb74adc73d621cdd2328cc6a4a2cea2b/50768/08_Data_Migration_Solution_Matillion_a69da6c438.
png","srcSet":"/static/cb74adc73d621cdd2328cc6a4a2cea2b/1167e/08_Data_Migration_Solution_Matillion_a69da6c438.png
428w,\\n/static/cb74adc73d621cdd2328cc6a4a2cea2b/4df1e/08_Data_Migration_Solution_Matillion_a69da6c438.png
856w,\\n/static/cb74adc73d621cdd2328cc6a4a2cea2b/50768/08_Data_Migration_Solution_Matillion_a69da6c438.png 1711w","sizes":"(min-width: 1711px) 1711px,
100vw"},"sources":[{"srcSet":"/static/cb74adc73d621cdd2328cc6a4a2cea2b/e4c2b/08_Data_Migration_Solution_Matillion_a69da6c438.webp
428w,\\n/static/cb74adc73d621cdd2328cc6a4a2cea2b/8de68/08_Data_Migration_Solution_Matillion_a69da6c438.webp
856w,\\n/static/cb74adc73d621cdd2328cc6a4a2cea2b/72c07/08_Data_Migration_Solution_Matillion_a69da6c438.webp 1711w","type":"image/webp","sizes":"(min-width: 1711px) 1711px,
100vw"}]},"width":1711,"height":638}',
    children: undefined
  }
}
Brenosalv commented 4 months ago

I think it's something related to the patch @draftbox-co+gatsby-rehype-inline-images+1.0.2.patch. Someway it's not setting the alt to the imgOptions properly.