search

eszdman / PhotonCamera

Android Camera that uses Enhanced image processing
GNU General Public License v3.0
755 stars 71 forks source link

Refactoring and Applying Design-Patterns #98

Closed Tigerfriend1 closed 1 year ago

Tigerfriend1 commented 1 year ago

Hello!

I am impressed by your open source PhotonCamera project.

So we just want to contribute a little to the project.

Six students from Pusan National University in Korea, including me, refactored a part of the project.

Without modifying the functionality, we focused on refactoring and applying design patterns. We have confirmed that the project functions normally through our own tests.

Detailed descriptions of each refactoring and design pattern application can be found in each commit.

The test devices we used were Xiaomi Redmi Note 7, Galaxy 10, and Galaxy 21.

Additionally, we have provided test cases for some of the refactored classes.

Thank you for reading!

Based on the SOLID-principle. Major Refactoring: Variable renaming, Eliminate code duplication Major Design Patterns: State pattern, Strategy pattern, Factory pattern

eszdman commented 1 year ago

Thanks for your work I appreciate it, but I need time to check the correctness of the work, I already found some bugs related to the interface, for example, the rotation of the interface does not work properly (too sensitive for one slope and not sensitive for another) after your improvements.

For testing, you can send preliminary versions to the testing group in a telegram: https://t.me/PhotonCameraEN

Tigerfriend1 commented 1 year ago

First, I appreciate your feedback.

Feel free to take enough time for thorough verification, and we don't intend to impose our result on you. If desired, you are also welcome to make modifications or deletions as necessary.

I will send the entire file through Telegram. And you can also see the entire file in https://github.com/Tigerfriend1/PhotonCamera