search

eta-dev / eta-docs

Documentation website for the Eta template engine
https://eta.js.org
7 stars 18 forks source link

Missing meta description for express example. #40

Closed coolaj86 closed 2 years ago

coolaj86 commented 2 years ago

Here's what people see when they post the express example:

Screen Shot 2022-01-27 at 11 56 50 PM

That sounds scary - not friendly, and not descriptive of Eta and the experience with Express.

It's missing

<head>
    <meta name="description" value="something friendly and encouraging goes here">
    <meta property="og:description" content="something friendly and encouraging goes here" />
    <meta property="og:image" content="https://example.com/screenshot.png" />
    <!-- ... -->
</head>
coolaj86 commented 2 years ago

I know nothing about Docusaurus. I couldn't figure out where the "html" files (or equivalent) are in the repo.

However, you probably know, and maybe this helps: https://docusaurus.io/docs/docusaurus-core

NaincyKumariKnoldus commented 2 years ago

Hey @coolaj86 Can I do this please?

coolaj86 commented 2 years ago

@NaincyKumariKnoldus I'm not a maintainer, just a reporter.

However, if you know what to do and can make a PR, I would think the maintainers would probably welcome it.

shadowtime2000 commented 2 years ago

@coolaj86 @NaincyKumariKnoldus Hi! Correct me if I am wrong, but I don't believe Docusaurus allows for the manual editing of such descriptions, so instead the :::danger tag could be moved down so it appears right before the actual JS that uses Express, which would be more fitting since it doesn't really have to do with the template files.