search

etcd-io / etcd

Distributed reliable key-value store for the most critical data of a distributed system
https://etcd.io
Apache License 2.0
47.95k stars 9.78k forks source link

Refactor Etcdserver.snapshot to extract compaction into a separate method #18808

Closed ahrtr closed 1 month ago

ahrtr commented 1 month ago

Since nobody proceeds with the proposal, so create a followup PR to https://github.com/etcd-io/etcd/pull/18635/files#r1778755879

cc @clement2026 @serathius

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/etcd/blob/main/OWNERS)~~ [ahrtr,serathius] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.75%. Comparing base (36d785d) to head (976e9ee). Report is 12 commits behind head on main.

:exclamation: Current head 976e9ee differs from pull request most recent head 694b0fb

Please upload reports for the commit 694b0fb to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/etcd-io/etcd/pull/18808?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [server/etcdserver/server.go](https://app.codecov.io/gh/etcd-io/etcd/pull/18808?src=pr&el=tree&filepath=server%2Fetcdserver%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2VydmVyL2V0Y2RzZXJ2ZXIvc2VydmVyLmdv) | `81.32% <100.00%> (-0.11%)` | :arrow_down: | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/etcd-io/etcd/pull/18808/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #18808 +/- ## ========================================== - Coverage 68.81% 68.75% -0.07% ========================================== Files 420 420 Lines 35512 35515 +3 ========================================== - Hits 24437 24417 -20 - Misses 9647 9669 +22 - Partials 1428 1429 +1 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/etcd-io/etcd/pull/18808?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/etcd-io/etcd/pull/18808?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [36d785d...694b0fb](https://app.codecov.io/gh/etcd-io/etcd/pull/18808?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).