search

etcd-io / website

etcd.io
https://etcd.io
Other
148 stars 297 forks source link

improving text for transactional write #905

Closed NavinShrinivas closed 4 days ago

NavinShrinivas commented 1 month ago

Pertains to issue #901. Doesn't have the GIF/video example attached. The text added in this PR is picked from the API documentation and I felt its relevant here as well.

k8s-ci-robot commented 1 month ago

Hi @NavinShrinivas. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ivanvc commented 1 month ago

Hi @NavinShrinivas, I just read about this PR in the #sig-etcd channel. Let's run the linter as a first pass, then I'll deliver a review :smile:

/ok-to-test

NavinShrinivas commented 1 month ago

/retest

NavinShrinivas commented 1 month ago

/retest

NavinShrinivas commented 1 month ago

@ivanvc

ivanvc commented 3 weeks ago

@NavinShrinivas, sorry for the late response. Please refer to https://github.com/etcd-io/website/issues/901#issuecomment-2444888021

NavinShrinivas commented 1 week ago

@jmhbnz Have included in 3.6 as well

jmhbnz commented 1 week ago

@jmhbnz Have included in 3.6 as well

Thanks @NavinShrinivas can you please address the lint failures in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/905/pull-website-lint/1856660762336956416 so we can merge? Thanks!

ivanvc commented 6 days ago

@jmhbnz, could you do a pass to check the documentation's accuracy? If it is, we'll just need a squash in the commits.

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, NavinShrinivas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/etcd-io/website/blob/main/OWNERS)~~ [jmhbnz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment