search

etesync / etesync-notes

An EteSync backed note taking app
https://www.etesync.com
Other
90 stars 12 forks source link

following README's dev instructions results fails (at least for me) #176

Open jzacsh opened 3 years ago

jzacsh commented 3 years ago

yarn web results in:

yarn run v1.22.11
$ expo start --web
Starting project at /tmp/src/etesync-notes
Unable to find expo in this project - have you run yarn / npm install yet?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

note i've had yarn run successfully, as well as npm install (trying to follow the above error's expo hint)

$ npm --version && yarn --version && expo-cli --version
7.20.3
1.22.11
4.9.1

possible lead: is it correct that the READMe says to have both yarn and npm installed?

tdl;dr maybe this is a "support" ticket (in which case, feel free to close it - i'm happy to try debugging live in the matrix room instead) but maybe something's off with the readme? wanna double-check before i investigate further

tasn commented 3 years ago

npm install may have littered your env.

Start from a fresh directory and follow the prerequisites - https://github.com/etesync/etesync-notes#prerequisites

I think the issue you are facing (and we should probably update the readme!) is that developing the web requires yarn add expo. We are however not adding this dep permanently because it adds non-free components to the Android and iOS bulids which we don't want.

jzacsh commented 3 years ago

Thanks, that worked and indeed I'm able to see the UI on localhost now.

I've started a pull request with the update to the readme you mention, and threw in a few other TODOs that might be helpful for me to figure out and include before I close that PR.

tasn commented 3 years ago

Great to hear! Cool, let me know once the PR is ready to review.