eth-brownie / brownie

A Python-based development and testing framework for smart contracts targeting the Ethereum Virtual Machine.
https://eth-brownie.readthedocs.io
MIT License
2.65k stars 552 forks source link

chore: fix empty remappings #1699

Closed albert-llimos closed 1 year ago

albert-llimos commented 1 year ago

What I did

If no remappings are used, Brownie should not be passing any remappings to Solc. However, it currently passes the absolute path to the packages folder. This causes the byte metadata hash obtained when compiling contracts to be different between users just because this unnecessary remapping is being passed to the compiler.

How I did it

When no remapping is being passed, an empty array should be returned instead of returning a dict with the packages full path.

How to verify it

Checklist