search

eth-cscs / stackinator

https://eth-cscs.github.io/stackinator/
BSD 3-Clause "New" or "Revised" License
19 stars 15 forks source link

fix --with-view argument in develop #147

Closed simonpintarelli closed 7 months ago

simonpintarelli commented 9 months ago

spack env activate has changed --with-view flag, it requires an argument in latest develop:

usage: spack env activate [-hp] [--sh | --csh | --fish | --bat | --pwsh] [--with-view name | --without-view] [--temp] [-d DIR]
                          [env]

positional arguments:
  env                   name of environment to activate

options:
...
  --with-view name, -v name
                        set runtime environment variables for specific view
...
simonpintarelli commented 8 months ago

@RMeli I've added a note to the documentation.

simonpintarelli commented 8 months ago

I've just noticed the following. Without --develop v0.20.1 doesn't work, as it uses -m flag, but not yet requires an argument for --view.

bcumming commented 7 months ago

I've just noticed the following. Without --develop v0.20.1 doesn't work, as it uses -m flag, but not yet requires an argument for --view.

The Spack devs don't have much respect for semantic versioning, unfortunately.

simonpintarelli commented 7 months ago

I've just noticed the following. Without --develop v0.20.1 doesn't work, as it uses -m flag, but not yet requires an argument for --view.

Looks like I confused something. In v0.21 --with-view requires an argument and buildcache create does not have the -m flag anymore.

RMeli commented 7 months ago

Looks like I confused something. In v0.21 --with-view requires an argument and buildcache create does not have the -m flag anymore.

I think the goal is to support two released versions, so now it would be v0.21 and v0.20. The -m option was required in v0.19, so it can be dropped.

If you agree to drop v0.19 support, I can open a PR.