search

eth-cscs / stackinator

https://eth-cscs.github.io/stackinator/
BSD 3-Clause "New" or "Revised" License
19 stars 15 forks source link

Add a couple of missing spack --color=never #184

Closed albestro closed 2 months ago

albestro commented 2 months ago

After https://github.com/spack/spack/pull/42334 stackinator started raising some errors due to colorised output.

Just for reference, the error look like this

env: ‘\033[1m/user-environment/linux-sles15-zen/gcc-7.5.0/squashfs-4.6.1-pl5475bjii2xaf3cafaflr2yidf5754h\033[0m/bin/mksquashfs’: No such file or directory

In other places spack --color=never is already used, so I just applied the same solution also in the other parts that were triggering the error.

This applies for sure to develop branch, but in principle it should not harm in general.

Actually, I think it might be a good idea to have a different $(SPACK) variable that already embeds the --color=never, so it can be safely used where we use spack not as build tool but as helper to retrieve information (e.g. get install prefix).

bcumming commented 2 months ago

Thanks @albestro.

I agree about replacing SPACK with SPACK_HELPER.

albestro commented 2 months ago

@bcumming is it the way you were thinking about it?