search

ethereum-optimism / design-docs

MIT License
27 stars 20 forks source link

Holocene: protocol - proposal for action-test based test-vectors #75

Closed protolambda closed 2 months ago

protolambda commented 2 months ago

Description

Early draft of a proposal for using action-tests as base for test-vector generation.

@clabby and @refcell own the direction for multi-client test vectors (feel free to make design-doc edits).

sebastianst commented 2 months ago

One line of work that I'd like to invest in as part of Holocene is to extract bits out of the batcher and make them reusable in the action tests. There's currently too much custom batcher implementation in the action tests, that we should be able to deduplicate.

joohhnnn commented 2 months ago

Hi @protolambda , could you clarify the scope of the data export? For instance, do we need to export all data, such as the pre and post states for all block mining and call executions? Or do we just need to record the pre and post states for transactions involving key components?

BlocksOnAChain commented 2 months ago

@clabby @refcell - Since I believe that we kinda made the decision on how we plan to proceed with testing for holocene and which approach we can use for action-tests, we can maybe close this PR now? If you folks are ok with that?

GrapeBaBa commented 2 months ago

@clabby @refcell - Since I believe that we kinda made the decision on how we plan to proceed with testing for holocene and which approach we can use for action-tests, we can maybe close this PR now? If you folks are ok with that?

Does closing this PR mean that development will follow this design in the future?

BlocksOnAChain commented 2 months ago

Closing this with a comments from our weekly:

@Ben Clabby -Proofs team already has everything they need. For us, it just reusing what we already have

@Sebastian Stammler On the other side, Holocene tests - we will create a framework that we need for Holocene, based on action tests.