ethereum-optimism / op-geth

GNU Lesser General Public License v3.0
280 stars 735 forks source link

🧹 chore: bump minimal go version writing on docs #309

Closed riemannulus closed 4 months ago

riemannulus commented 5 months ago

Description

Since #230, optimism's go.mod depends on toolchain. Since the toolchain has been applied since go version 1.21, the programmer must maintain go version at least 1.21 or higher to build optimism. However, README.md indicates that the minimum version is 1.19, which can be confusing. This PR should be resolve it.

Additional context

I have not checked whether the same problem exists in other documents in the repository.

riemannulus commented 5 months ago

I don't know who to ask for a review. Please help in this regard.

ajsutton commented 4 months ago

Thanks but given this doc has been fixed in the upstream, the fix will come through as we pull in the next upstream release. Work is ongoing currently to catch us up with pending changes in other PRs so I'm going to close this one to avoid creating conflicts with upstream.