ethereum-optimism / optimistic-specs

Optimistic: Bedrock, is a protocol that strives to be an extremely simple optimistic rollup that maintains 1:1 compatibility with Ethereum
MIT License
167 stars 35 forks source link

feat: eip 1159 like pricing for deposits charged on L1 #438

Closed tynes closed 2 years ago

tynes commented 2 years ago

Description Meter deposits on L1, WIP

Implements https://github.com/ethereum-optimism/optimistic-specs/pull/401

Replaces:

Metadata Fixes: ENG-2187

codecov-commenter commented 2 years ago

Codecov Report

Merging #438 (d45baa7) into main (5b692b5) will decrease coverage by 0.18%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   51.86%   51.68%   -0.19%     
==========================================
  Files          63      133      +70     
  Lines        6696    14278    +7582     
==========================================
+ Hits         3473     7379    +3906     
- Misses       2784     5937    +3153     
- Partials      439      962     +523     
Flag Coverage Δ
unittests 51.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/l1/request_sema.go 100.00% <0.00%> (ø)
op-node/node/api.go 59.25% <0.00%> (ø)
op-node/node/bundle_builder.go 100.00% <0.00%> (ø)
op-proposer/mock/l1client.go 0.00% <0.00%> (ø)
op-node/rollup/derive/batch.go 52.05% <0.00%> (ø)
op-node/node/config.go 33.33% <0.00%> (ø)
op-node/l1/source.go 58.64% <0.00%> (ø)
op-node/backoff/operation.go 88.88% <0.00%> (ø)
op-node/rollup/driver/driver.go 100.00% <0.00%> (ø)
op-node/p2p/config.go 7.83% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b692b5...d45baa7. Read the comment docs.

tynes commented 2 years ago

Simple way: if msg.value > 0; payable path; else burnable path

trianglesphere commented 2 years ago

Closing in favor of https://github.com/ethereum-optimism/optimism/pull/2575